fix(player): 评论面板自适应高度并只顶起输入框
This commit is contained in:
1 parent
97735763a1
commit
ab476cab7d
3 files changed
+266
-99
No files matched your search
@@ -46,7 +46,7 @@ class CommentTile extends StatelessWidget {
|
|||||||
: comment.nickname;
|
: comment.nickname;
|
||||||
return Padding(
|
return Padding(
|
||||||
key: Key('comment-item-${comment.id}'),
|
key: Key('comment-item-${comment.id}'),
|
||||||
padding: const EdgeInsets.only(top: 12, bottom: 14),
|
padding: const EdgeInsets.only(top: 10, bottom: 12),
|
||||||
child: Row(
|
child: Row(
|
||||||
crossAxisAlignment: CrossAxisAlignment.start,
|
crossAxisAlignment: CrossAxisAlignment.start,
|
||||||
children: [
|
children: [
|
||||||
@@ -125,7 +125,7 @@ class CommentTile extends StatelessWidget {
|
|||||||
),
|
),
|
||||||
if (comment.createdAt != null || !isReply)
|
if (comment.createdAt != null || !isReply)
|
||||||
Padding(
|
Padding(
|
||||||
padding: const EdgeInsets.only(top: 6),
|
padding: const EdgeInsets.only(top: 4),
|
||||||
child: _metadata(context, l10n),
|
child: _metadata(context, l10n),
|
||||||
),
|
),
|
||||||
],
|
],
|
||||||
|
|||||||
@@ -29,6 +29,8 @@ const double _sendButtonSize = 38;
|
|||||||
const double _sheetRadius = 20;
|
const double _sheetRadius = 20;
|
||||||
const double _headerHeight = 44;
|
const double _headerHeight = 44;
|
||||||
const double _replyIndent = 52;
|
const double _replyIndent = 52;
|
||||||
|
const double _composerTopGap = 8;
|
||||||
|
const double _replyBannerHeight = 46;
|
||||||
|
|
||||||
/// 服务端评论底部弹窗:匿名列表、游标翻页、回复、举报和本人删除。
|
/// 服务端评论底部弹窗:匿名列表、游标翻页、回复、举报和本人删除。
|
||||||
class DramaCommentsSheet extends StatefulWidget {
|
class DramaCommentsSheet extends StatefulWidget {
|
||||||
@@ -178,114 +180,170 @@ class _DramaCommentsSheetState extends State<DramaCommentsSheet> {
|
|||||||
|
|
||||||
@override
|
@override
|
||||||
Widget build(BuildContext context) {
|
Widget build(BuildContext context) {
|
||||||
final available =
|
final screenLimit = MediaQuery.sizeOf(context).height - 24;
|
||||||
MediaQuery.sizeOf(context).height -
|
final maxHeight = screenLimit < _maxSheetHeight
|
||||||
MediaQuery.viewInsetsOf(context).bottom -
|
? screenLimit
|
||||||
24;
|
: _maxSheetHeight;
|
||||||
return Padding(
|
return Container(
|
||||||
padding: EdgeInsets.only(bottom: MediaQuery.viewInsetsOf(context).bottom),
|
key: const Key('player-comments-sheet'),
|
||||||
child: Container(
|
decoration: const BoxDecoration(
|
||||||
key: const Key('player-comments-sheet'),
|
color: AppColors.card,
|
||||||
decoration: const BoxDecoration(
|
borderRadius: BorderRadius.vertical(top: Radius.circular(_sheetRadius)),
|
||||||
color: AppColors.card,
|
),
|
||||||
borderRadius: BorderRadius.vertical(
|
child: SafeArea(
|
||||||
top: Radius.circular(_sheetRadius),
|
top: false,
|
||||||
),
|
child: ListenableBuilder(
|
||||||
),
|
listenable: _controller,
|
||||||
child: SizedBox(
|
builder: (context, _) {
|
||||||
height: available.clamp(_minSheetHeight, _maxSheetHeight),
|
final minHeight = _controller.comments.isEmpty
|
||||||
child: SafeArea(
|
? (_minSheetHeight < maxHeight ? _minSheetHeight : maxHeight)
|
||||||
top: false,
|
: 0.0;
|
||||||
child: Padding(
|
return ConstrainedBox(
|
||||||
padding: const EdgeInsets.fromLTRB(12, 4, 12, 12),
|
key: const Key('comment-sheet-constraints'),
|
||||||
child: ListenableBuilder(
|
constraints: BoxConstraints(
|
||||||
listenable: _controller,
|
minHeight: minHeight,
|
||||||
builder: (context, _) => _content(context),
|
maxHeight: maxHeight,
|
||||||
),
|
),
|
||||||
),
|
child: Padding(
|
||||||
),
|
padding: const EdgeInsets.symmetric(horizontal: 16),
|
||||||
|
child: _content(context, maxHeight),
|
||||||
|
),
|
||||||
|
);
|
||||||
|
},
|
||||||
),
|
),
|
||||||
),
|
),
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
Widget _content(BuildContext context) {
|
Widget _content(BuildContext context, double maxHeight) {
|
||||||
final l10n = AppLocalizations.of(context)!;
|
final l10n = AppLocalizations.of(context)!;
|
||||||
final count = _serverCount ?? _controller.exactCount;
|
final count = _serverCount ?? _controller.exactCount;
|
||||||
return Column(
|
final replyReserve = _replyTo == null ? 0.0 : _replyBannerHeight;
|
||||||
crossAxisAlignment: CrossAxisAlignment.start,
|
final listMaxHeight =
|
||||||
|
maxHeight -
|
||||||
|
_headerHeight -
|
||||||
|
_composerHeight -
|
||||||
|
_composerTopGap -
|
||||||
|
replyReserve;
|
||||||
|
return Stack(
|
||||||
children: [
|
children: [
|
||||||
SizedBox(
|
Column(
|
||||||
height: _headerHeight,
|
key: const Key('comment-sheet-content'),
|
||||||
width: double.infinity,
|
mainAxisSize: MainAxisSize.min,
|
||||||
child: Stack(
|
crossAxisAlignment: CrossAxisAlignment.start,
|
||||||
alignment: Alignment.center,
|
children: [
|
||||||
children: [
|
SizedBox(
|
||||||
Text(
|
height: _headerHeight,
|
||||||
count == null ? l10n.comments : l10n.commentsWithCount(count),
|
width: double.infinity,
|
||||||
key: const Key('comment-count-label'),
|
child: Stack(
|
||||||
textAlign: TextAlign.center,
|
alignment: Alignment.center,
|
||||||
style: const TextStyle(
|
children: [
|
||||||
color: AppColors.onSurface,
|
Text(
|
||||||
fontSize: 16,
|
count == null
|
||||||
fontWeight: FontWeight.w600,
|
? l10n.comments
|
||||||
),
|
: l10n.commentsWithCount(count),
|
||||||
),
|
key: const Key('comment-count-label'),
|
||||||
Positioned(
|
textAlign: TextAlign.center,
|
||||||
left: 0,
|
style: const TextStyle(
|
||||||
child: SizedBox.square(
|
color: AppColors.onSurface,
|
||||||
dimension: 44,
|
fontSize: 16,
|
||||||
child: IconButton(
|
fontWeight: FontWeight.w600,
|
||||||
key: const Key('player-comments-close'),
|
|
||||||
tooltip: l10n.close,
|
|
||||||
padding: EdgeInsets.zero,
|
|
||||||
onPressed: () => Navigator.pop(context),
|
|
||||||
icon: const Icon(
|
|
||||||
Icons.keyboard_arrow_down_rounded,
|
|
||||||
size: 24,
|
|
||||||
color: AppColors.cream,
|
|
||||||
),
|
),
|
||||||
),
|
),
|
||||||
),
|
Positioned(
|
||||||
|
left: 0,
|
||||||
|
child: SizedBox.square(
|
||||||
|
dimension: 44,
|
||||||
|
child: IconButton(
|
||||||
|
key: const Key('player-comments-close'),
|
||||||
|
tooltip: l10n.close,
|
||||||
|
padding: EdgeInsets.zero,
|
||||||
|
onPressed: () => Navigator.pop(context),
|
||||||
|
icon: const Icon(
|
||||||
|
Icons.keyboard_arrow_down_rounded,
|
||||||
|
size: 24,
|
||||||
|
color: AppColors.cream,
|
||||||
|
),
|
||||||
|
),
|
||||||
|
),
|
||||||
|
),
|
||||||
|
],
|
||||||
),
|
),
|
||||||
],
|
),
|
||||||
|
ConstrainedBox(
|
||||||
|
constraints: BoxConstraints(
|
||||||
|
maxHeight: listMaxHeight < 0 ? 0 : listMaxHeight,
|
||||||
|
),
|
||||||
|
child: _list(l10n),
|
||||||
|
),
|
||||||
|
if (_replyTo != null) _replyBanner(l10n, _replyTo!),
|
||||||
|
const SizedBox(
|
||||||
|
height: _composerHeight + _composerTopGap,
|
||||||
|
),
|
||||||
|
],
|
||||||
|
),
|
||||||
|
Positioned(
|
||||||
|
left: 0,
|
||||||
|
right: 0,
|
||||||
|
bottom: 0,
|
||||||
|
child: AnimatedPadding(
|
||||||
|
duration: const Duration(milliseconds: 150),
|
||||||
|
curve: Curves.easeOut,
|
||||||
|
padding: EdgeInsets.only(
|
||||||
|
bottom: MediaQuery.viewInsetsOf(context).bottom,
|
||||||
|
),
|
||||||
|
child: Padding(
|
||||||
|
padding: const EdgeInsets.only(top: _composerTopGap),
|
||||||
|
child: _composer(l10n),
|
||||||
|
),
|
||||||
),
|
),
|
||||||
),
|
),
|
||||||
const SizedBox(height: 8),
|
|
||||||
Expanded(child: _list(l10n)),
|
|
||||||
if (_replyTo != null) _replyBanner(l10n, _replyTo!),
|
|
||||||
_composer(l10n),
|
|
||||||
],
|
],
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
Widget _list(AppLocalizations l10n) {
|
Widget _list(AppLocalizations l10n) {
|
||||||
|
final keyboardHeight = MediaQuery.viewInsetsOf(context).bottom;
|
||||||
if (_controller.loading && _controller.comments.isEmpty) {
|
if (_controller.loading && _controller.comments.isEmpty) {
|
||||||
return const Center(
|
return const Padding(
|
||||||
child: CircularProgressIndicator(key: Key('comment-list-loading')),
|
padding: EdgeInsets.only(top: 4),
|
||||||
|
child: Center(
|
||||||
|
child: CircularProgressIndicator(key: Key('comment-list-loading')),
|
||||||
|
),
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
if (_controller.error != null && _controller.comments.isEmpty) {
|
if (_controller.error != null && _controller.comments.isEmpty) {
|
||||||
return EmptyState(
|
return Padding(
|
||||||
key: const Key('comment-list-error'),
|
padding: const EdgeInsets.only(top: 4),
|
||||||
icon: Icons.cloud_off_rounded,
|
child: EmptyState(
|
||||||
title: errorText(l10n, _controller.error, l10n.commentsLoadFailed),
|
key: const Key('comment-list-error'),
|
||||||
actionLabel: l10n.retry,
|
icon: Icons.cloud_off_rounded,
|
||||||
actionKey: const Key('comment-list-retry'),
|
title: errorText(l10n, _controller.error, l10n.commentsLoadFailed),
|
||||||
onAction: _controller.load,
|
actionLabel: l10n.retry,
|
||||||
compact: true,
|
actionKey: const Key('comment-list-retry'),
|
||||||
|
onAction: _controller.load,
|
||||||
|
compact: true,
|
||||||
|
),
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
if (_controller.comments.isEmpty) {
|
if (_controller.comments.isEmpty) {
|
||||||
return EmptyState(
|
return Padding(
|
||||||
key: const Key('comment-list-empty'),
|
padding: const EdgeInsets.only(top: 4),
|
||||||
icon: Icons.chat_bubble_outline_rounded,
|
child: EmptyState(
|
||||||
title: l10n.noComments,
|
key: const Key('comment-list-empty'),
|
||||||
compact: true,
|
icon: Icons.chat_bubble_outline_rounded,
|
||||||
|
title: l10n.noComments,
|
||||||
|
compact: true,
|
||||||
|
),
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
return ListView.builder(
|
return ListView.builder(
|
||||||
key: const Key('comment-list'),
|
key: const Key('comment-list'),
|
||||||
|
shrinkWrap: true,
|
||||||
|
padding: EdgeInsets.only(
|
||||||
|
top: 4,
|
||||||
|
bottom: _composerHeight + keyboardHeight,
|
||||||
|
),
|
||||||
itemCount: _controller.comments.length + 1,
|
itemCount: _controller.comments.length + 1,
|
||||||
itemBuilder: (context, index) {
|
itemBuilder: (context, index) {
|
||||||
if (index == _controller.comments.length) return _footer(l10n);
|
if (index == _controller.comments.length) return _footer(l10n);
|
||||||
@@ -319,26 +377,31 @@ class _DramaCommentsSheetState extends State<DramaCommentsSheet> {
|
|||||||
return const SizedBox(height: 8);
|
return const SizedBox(height: 8);
|
||||||
}
|
}
|
||||||
|
|
||||||
Widget _replyBanner(AppLocalizations l10n, DramaComment replyTo) => Padding(
|
Widget _replyBanner(AppLocalizations l10n, DramaComment replyTo) => SizedBox(
|
||||||
padding: const EdgeInsets.only(bottom: 6),
|
height: _replyBannerHeight,
|
||||||
child: Row(
|
child: Padding(
|
||||||
children: [
|
padding: const EdgeInsets.only(bottom: 6),
|
||||||
Expanded(
|
child: Row(
|
||||||
child: Text(
|
children: [
|
||||||
l10n.replyingTo(
|
Expanded(
|
||||||
replyTo.nickname.isEmpty ? l10n.anonymousUser : replyTo.nickname,
|
child: Text(
|
||||||
|
l10n.replyingTo(
|
||||||
|
replyTo.nickname.isEmpty
|
||||||
|
? l10n.anonymousUser
|
||||||
|
: replyTo.nickname,
|
||||||
|
),
|
||||||
|
style: const TextStyle(color: AppColors.muted, fontSize: 12),
|
||||||
),
|
),
|
||||||
style: const TextStyle(color: AppColors.muted, fontSize: 12),
|
|
||||||
),
|
),
|
||||||
),
|
IconButton(
|
||||||
IconButton(
|
key: const Key('comment-cancel-reply'),
|
||||||
key: const Key('comment-cancel-reply'),
|
tooltip: l10n.cancelReply,
|
||||||
tooltip: l10n.cancelReply,
|
onPressed: _cancelReply,
|
||||||
onPressed: _cancelReply,
|
visualDensity: VisualDensity.compact,
|
||||||
visualDensity: VisualDensity.compact,
|
icon: const Icon(Icons.close_rounded, size: 18),
|
||||||
icon: const Icon(Icons.close_rounded, size: 18),
|
),
|
||||||
),
|
],
|
||||||
],
|
),
|
||||||
),
|
),
|
||||||
);
|
);
|
||||||
|
|
||||||
|
|||||||
@@ -305,6 +305,101 @@ void main() {
|
|||||||
);
|
);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
testWidgets('should_size_short_list_to_content', (tester) async {
|
||||||
|
tester.view.physicalSize = const Size(390, 844);
|
||||||
|
tester.view.devicePixelRatio = 1;
|
||||||
|
addTearDown(tester.view.resetPhysicalSize);
|
||||||
|
addTearDown(tester.view.resetDevicePixelRatio);
|
||||||
|
final repository = FakeCommentRepository(
|
||||||
|
pages: [
|
||||||
|
CommentPage(
|
||||||
|
comments: [
|
||||||
|
commentFixture(id: '10', content: 'Short list one'),
|
||||||
|
commentFixture(id: '11', content: 'Short list two'),
|
||||||
|
],
|
||||||
|
),
|
||||||
|
],
|
||||||
|
);
|
||||||
|
|
||||||
|
await _pumpSheet(tester, repository: repository);
|
||||||
|
|
||||||
|
final sheet = find.byKey(const Key('player-comments-sheet'));
|
||||||
|
expect(tester.getSize(sheet).height, lessThan(520));
|
||||||
|
final lastCommentBottom = tester
|
||||||
|
.getBottomLeft(find.byKey(const Key('comment-item-11')))
|
||||||
|
.dy;
|
||||||
|
final composerTop = tester
|
||||||
|
.getTopLeft(find.byKey(const Key('comment-composer')))
|
||||||
|
.dy;
|
||||||
|
expect(composerTop - lastCommentBottom, lessThan(80));
|
||||||
|
});
|
||||||
|
|
||||||
|
testWidgets('should_keep_minimum_height_for_empty_state', (tester) async {
|
||||||
|
final repository = FakeCommentRepository(pages: [const CommentPage()]);
|
||||||
|
|
||||||
|
await _pumpSheet(tester, repository: repository);
|
||||||
|
|
||||||
|
expect(
|
||||||
|
tester.getSize(find.byKey(const Key('player-comments-sheet'))).height,
|
||||||
|
greaterThanOrEqualTo(220),
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
testWidgets('should_keep_long_comment_list_scrollable', (tester) async {
|
||||||
|
tester.view.physicalSize = const Size(390, 844);
|
||||||
|
tester.view.devicePixelRatio = 1;
|
||||||
|
addTearDown(tester.view.resetPhysicalSize);
|
||||||
|
addTearDown(tester.view.resetDevicePixelRatio);
|
||||||
|
final repository = FakeCommentRepository(
|
||||||
|
pages: [CommentPage(comments: _comments(30))],
|
||||||
|
);
|
||||||
|
|
||||||
|
await _pumpSheet(tester, repository: repository);
|
||||||
|
final scrolledComment = find.byKey(const Key('comment-item-12'));
|
||||||
|
final before = tester.getTopLeft(scrolledComment).dy;
|
||||||
|
|
||||||
|
await tester.drag(
|
||||||
|
find.byKey(const Key('comment-list')),
|
||||||
|
const Offset(0, -300),
|
||||||
|
);
|
||||||
|
await tester.pumpAndSettle();
|
||||||
|
|
||||||
|
expect(tester.getTopLeft(scrolledComment).dy, lessThan(before));
|
||||||
|
expect(
|
||||||
|
tester.getSize(find.byKey(const Key('player-comments-sheet'))).height,
|
||||||
|
520,
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
testWidgets('should_keep_sheet_fixed_and_move_only_composer_for_keyboard', (
|
||||||
|
tester,
|
||||||
|
) async {
|
||||||
|
tester.view.physicalSize = const Size(390, 844);
|
||||||
|
tester.view.devicePixelRatio = 1;
|
||||||
|
addTearDown(tester.view.resetPhysicalSize);
|
||||||
|
addTearDown(tester.view.resetDevicePixelRatio);
|
||||||
|
addTearDown(tester.view.resetViewInsets);
|
||||||
|
final repository = FakeCommentRepository(
|
||||||
|
pages: [CommentPage(comments: _comments(30))],
|
||||||
|
);
|
||||||
|
|
||||||
|
await _pumpSheet(tester, repository: repository);
|
||||||
|
final sheet = find.byKey(const Key('player-comments-sheet'));
|
||||||
|
final input = find.byKey(const Key('comment-composer'));
|
||||||
|
final first = find.byKey(const Key('comment-item-10'));
|
||||||
|
final sheetTop = tester.getTopLeft(sheet).dy;
|
||||||
|
final inputTop = tester.getTopLeft(input).dy;
|
||||||
|
final firstTop = tester.getTopLeft(first).dy;
|
||||||
|
|
||||||
|
tester.view.viewInsets = const FakeViewPadding(bottom: 180);
|
||||||
|
await tester.pump();
|
||||||
|
await tester.pump(const Duration(milliseconds: 160));
|
||||||
|
|
||||||
|
expect(tester.getTopLeft(sheet).dy, closeTo(sheetTop, 0.1));
|
||||||
|
expect(tester.getTopLeft(first).dy, closeTo(firstTop, 0.1));
|
||||||
|
expect(tester.getTopLeft(input).dy, lessThan(inputTop - 100));
|
||||||
|
});
|
||||||
|
|
||||||
testWidgets('should_hide_comment_like_controls', (tester) async {
|
testWidgets('should_hide_comment_like_controls', (tester) async {
|
||||||
final repository = FakeCommentRepository(
|
final repository = FakeCommentRepository(
|
||||||
pages: [
|
pages: [
|
||||||
@@ -560,7 +655,11 @@ Future<AuthController> _pumpSheet(
|
|||||||
'/': (_) => const Scaffold(backgroundColor: AppColors.ink),
|
'/': (_) => const Scaffold(backgroundColor: AppColors.ink),
|
||||||
'/comments': (_) => const Scaffold(
|
'/comments': (_) => const Scaffold(
|
||||||
backgroundColor: AppColors.ink,
|
backgroundColor: AppColors.ink,
|
||||||
body: DramaCommentsSheet(drama: _drama),
|
resizeToAvoidBottomInset: false,
|
||||||
|
body: Align(
|
||||||
|
alignment: Alignment.bottomCenter,
|
||||||
|
child: DramaCommentsSheet(drama: _drama),
|
||||||
|
),
|
||||||
),
|
),
|
||||||
},
|
},
|
||||||
),
|
),
|
||||||
@@ -602,6 +701,11 @@ Future<AuthController> _auth() async {
|
|||||||
return auth;
|
return auth;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
List<DramaComment> _comments(int count) => [
|
||||||
|
for (var index = 0; index < count; index++)
|
||||||
|
commentFixture(id: '${index + 10}', content: 'Comment ${index + 1}'),
|
||||||
|
];
|
||||||
|
|
||||||
class _TestAuthController extends AuthController {
|
class _TestAuthController extends AuthController {
|
||||||
_TestAuthController(super.api, super.store, {required this._signedIn});
|
_TestAuthController(super.api, super.store, {required this._signedIn});
|
||||||
|
|
||||||
|
|||||||
Reference in new issue
Block a user